All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: davem@davemloft.net
Cc: yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [PATCH] fib6: Fix fn->leaf == NULL race when inserting new nodes in fib6 tree
Date: Thu, 4 Jan 2007 20:21:47 +0100	[thread overview]
Message-ID: <20070104192147.GD8693@postel.suug.ch> (raw)
In-Reply-To: <20070104093921.GC8693@postel.suug.ch>

* Thomas Graf <tgraf@suug.ch> 2007-01-04 10:39
> When inserting new nodes into a fib6 tree, the leaf pointer
> is first to NULL and later corrected when the key gets
> assigned. However, the tree is not locked for this period
> of time, therefore nodes with an invalid leaf pointer
> are accessible. Lookups that occur during this period of time
> expect a valid leaf pointer and thus crash.
> 
> This patch sets the leaf pointer to ip6_null_entry during
> this critical period of time.

Ignore this patch for now, the description is certainly inaccurate
even though it seems to fix the issue.

  reply	other threads:[~2007-01-04 19:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-04  9:39 [PATCH] fib6: Fix fn->leaf == NULL race when inserting new nodes in fib6 tree Thomas Graf
2007-01-04 19:21 ` Thomas Graf [this message]
2007-01-04 20:24   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070104192147.GD8693@postel.suug.ch \
    --to=tgraf@suug.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.