From: "Cyrill V. Gorcunov" <gorcunov@gmail.com>
To: bjdouma@xs4all.nl
Cc: kernel list <linux-kernel@vger.kernel.org>,
Randy Dunlap <randy.dunlap@oracle.com>
Subject: Re: qconf: reproducible segfault
Date: Thu, 4 Jan 2007 20:14:11 +0300 [thread overview]
Message-ID: <200701042014.12473.gorcunov@gmail.com> (raw)
In-Reply-To: <459C1966.7040209@xs4all.nl>
[-- Attachment #1: Type: text/plain, Size: 87 bytes --]
Please try patch I've enveloped. And write me does it fix your problem?
--
- Cyrill
[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 1230 bytes --]
diff --git a/scripts/kconfig/qconf.cc b/scripts/kconfig/qconf.cc
index 0b2fcc4..0694d1d 100644
--- a/scripts/kconfig/qconf.cc
+++ b/scripts/kconfig/qconf.cc
@@ -925,6 +925,8 @@ ConfigInfoView::ConfigInfoView(QWidget* parent, const char *name)
configSettings->endGroup();
connect(configApp, SIGNAL(aboutToQuit()), SLOT(saveSettings()));
}
+
+ has_dbg_info = 0;
}
void ConfigInfoView::saveSettings(void)
@@ -953,10 +955,13 @@ void ConfigInfoView::setInfo(struct menu *m)
if (menu == m)
return;
menu = m;
- if (!menu)
+ if (!menu) {
+ has_dbg_info = 0;
clear();
- else
+ } else {
+ has_dbg_info = 1;
menuInfo();
+ }
}
void ConfigInfoView::setSource(const QString& name)
@@ -991,6 +996,9 @@ void ConfigInfoView::symbolInfo(void)
{
QString str;
+ if (!has_dbg_info)
+ return;
+
str += "<big>Symbol: <b>";
str += print_filter(sym->name);
str += "</b></big><br><br>value: ";
diff --git a/scripts/kconfig/qconf.h b/scripts/kconfig/qconf.h
index 6fc1c5f..a397edb 100644
--- a/scripts/kconfig/qconf.h
+++ b/scripts/kconfig/qconf.h
@@ -273,6 +273,8 @@ protected:
struct symbol *sym;
struct menu *menu;
bool _showDebug;
+
+ int has_dbg_info;
};
class ConfigSearchWindow : public QDialog {
next prev parent reply other threads:[~2007-01-04 17:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-03 21:00 qconf: reproducible segfault Bauke Jan Douma
2007-01-03 21:35 ` Randy Dunlap
2007-01-04 0:32 ` Alessandro Suardi
2007-01-04 9:42 ` Cyrill V. Gorcunov
[not found] ` <5a4c581d0701041316w83d1564rac875a1d4e0ef87a@mail.gmail.com>
[not found] ` <200701051022.59914.gorcunov@gmail.com>
2007-01-05 21:28 ` Alessandro Suardi
2007-01-04 17:14 ` Cyrill V. Gorcunov [this message]
2007-01-04 17:15 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701042014.12473.gorcunov@gmail.com \
--to=gorcunov@gmail.com \
--cc=bjdouma@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.