From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1H2dTX-0000Ms-VP
	for qemu-devel@nongnu.org; Thu, 04 Jan 2007 20:02:28 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1H2dTU-0000KA-CH
	for qemu-devel@nongnu.org; Thu, 04 Jan 2007 20:02:27 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1H2dTT-0000Jx-Ss
	for qemu-devel@nongnu.org; Thu, 04 Jan 2007 20:02:23 -0500
Received: from [193.7.176.60] (helo=mail.bawue.net)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1H2dTT-0006SI-67
	for qemu-devel@nongnu.org; Thu, 04 Jan 2007 20:02:23 -0500
Received: from lagash (88-106-179-150.dynamic.dsl.as9105.com [88.106.179.150])
	(using TLSv1 with cipher AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.bawue.net (Postfix) with ESMTP id 9E1F6B9EDE
	for <qemu-devel@nongnu.org>; Fri,  5 Jan 2007 02:02:21 +0100 (CET)
Received: from ths by lagash with local (Exim 4.63)
	(envelope-from <ths@networkno.de>) id 1H2dUH-0004T3-5D
	for qemu-devel@nongnu.org; Fri, 05 Jan 2007 01:03:13 +0000
Date: Fri, 5 Jan 2007 01:03:13 +0000
From: Thiemo Seufer <ths@networkno.de>
Subject: Re: [Qemu-devel] qemu Makefile configure
Message-ID: <20070105010313.GA14085@networkno.de>
References: <E1H1UkH-00031L-K0@savannah.gnu.org>
	<20070103135950.GB5849@networkno.de> <459BCF30.5010200@bellard.org>
	<20070103161653.GF5849@networkno.de>
	<20070104122656.GA708@networkno.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070104122656.GA708@networkno.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Thiemo Seufer wrote:
> Thiemo Seufer wrote:
> > Fabrice Bellard wrote:
> > > IMHO, CFLAGS and LDFLAGS overriding should not be allowed for QEMU as it 
> > > is almost sure to break the dyngen stuff. If ever it is allowed, it 
> > > should be done so that the CFLAGS for the files used by dyngen are not 
> > > modified.
> > 
> > That's why I made OP_CFLAGS a separate set of flags.
> > 
> > I append the next version of the patch, which incorporates the
> > suggestions made by Daniel and Bernhard, and fixes a gcc3 detection
> > bug I introduced earlier.
> 
> Next iteration, this uses BASE_CFLAGS and BASE_LDFLAGS instead of
> gmake's override feature.

Comitted, since it held up well for several people.


Thiemo