From: Matthew Wilcox <matthew@wil.cx>
To: Erez Zadok <ezk@cs.sunysb.edu>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
Chaitanya Patti <crpatti@cs.sunysb.edu>,
linux-fsdevel@vger.kernel.org
Subject: Re: Is a NULL check missing in nfs_lookup?
Date: Fri, 5 Jan 2007 12:23:04 -0700 [thread overview]
Message-ID: <20070105192304.GH24620@parisc-linux.org> (raw)
In-Reply-To: <200701051910.l05JA6iq011061@agora.fsl.cs.sunysb.edu>
On Fri, Jan 05, 2007 at 02:10:06PM -0500, Erez Zadok wrote:
> Ah, ok. So why not put an ASSERT in there, or at least a comment, to make
> the code clearer. As it stands, anyone looking at the code in the future
> can easily rediscover this "bug" that dereferences a null ptr.
Because anyone poking in the VFS should take the time to understand
how it works? Adding crap like BUG_ON(!nd) is pointless -- you don't
get a clearer backtrace from that than you do from a null pointer.
next prev parent reply other threads:[~2007-01-05 19:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 0:00 Is a NULL check missing in nfs_lookup? Chaitanya Patti
2007-01-05 0:47 ` Shaya Potter
2007-01-05 1:59 ` Josef Sipek
2007-01-07 14:13 ` Ian Kent
2007-01-05 12:22 ` Trond Myklebust
2007-01-05 15:00 ` Shaya Potter
2007-01-05 16:01 ` Trond Myklebust
2007-01-05 17:11 ` Shaya Potter
2007-01-05 17:22 ` Al Viro
2007-01-05 17:22 ` Matthew Wilcox
2007-01-06 7:36 ` Why not pass "vfsmount" to VFS functions? Tetsuo Handa
2007-01-05 19:10 ` Is a NULL check missing in nfs_lookup? Erez Zadok
2007-01-05 19:23 ` Matthew Wilcox [this message]
2007-01-05 19:41 ` Muli Ben-Yehuda
2007-01-05 20:13 ` Erez Zadok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070105192304.GH24620@parisc-linux.org \
--to=matthew@wil.cx \
--cc=crpatti@cs.sunysb.edu \
--cc=ezk@cs.sunysb.edu \
--cc=linux-fsdevel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.