From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>, akpm <akpm@osdl.org>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Discuss a couple common errors in kernel-doc usage.
Date: Sat, 6 Jan 2007 20:00:45 -0800 [thread overview]
Message-ID: <20070106200045.43683769.randy.dunlap@oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0701051000560.3949@localhost.localdomain>
On Fri, 5 Jan 2007 10:03:53 -0500 (EST) Robert P. J. Day wrote:
>
> Explain a couple of the most common errors in kernel-doc usage.
>
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
It seems that you have been looking at my kdoc todo list....
> ---
>
> seems useful to emphasize these issues since they occur occasionally
> in the source.
>
> diff --git a/Documentation/kernel-doc-nano-HOWTO.txt b/Documentation/kernel-doc-nano-HOWTO.txt
> index 284e7e1..ba50129 100644
> --- a/Documentation/kernel-doc-nano-HOWTO.txt
> +++ b/Documentation/kernel-doc-nano-HOWTO.txt
> @@ -107,10 +107,14 @@ The format of the block comment is like this:
> * (section header: (section description)? )*
> (*)?*/
>
> -The short function description cannot be multiline, but the other
> -descriptions can be (and they can contain blank lines). Avoid putting a
> -spurious blank line after the function name, or else the description will
> -be repeated!
> +The short function description ***cannot be multiline***, but the other
> +descriptions can be (and they can contain blank lines). If you continue
> +that initial short description onto a second line, that second line will
> +appear further down at the beginning of the description section, which is
> +almost certainly not what you had in mind.
> +
> +Avoid putting a spurious blank line after the function name, or else the
> +description will be repeated!
>
> All descriptive text is further processed, scanning for the following special
> patterns, which are highlighted appropriately.
> @@ -121,6 +125,31 @@ patterns, which are highlighted appropriately.
> '@parameter' - name of a parameter
> '%CONST' - name of a constant.
>
> +NOTE 1: The multi-line descriptive text you provide does *not* recognize
> +line breaks, so if you try to format some text nicely, as in:
> +
> + Return codes
> + 0 - cool
> + 1 - invalid arg
> + 2 - out of memory
> +
> +this will all run together and produce:
> +
> + Return codes 0 - cool 1 - invalid arg 2 - out of memory
> +
> +NOTE 2: If the descriptive text you provide has lines that begin with
> +some phrase followed by a colon, each of those phrases will be taken as
> +a new section heading, which means you should similarly try to avoid text
> +like:
> +
> + Return codes:
> + 0: cool
> + 1: invalid arg
> + 2: out of memory
> +
> +every line of which would start a new section. Again, probably not
> +what you were after.
> +
> Take a look around the source tree for examples.
>
>
> -
---
~Randy
next prev parent reply other threads:[~2007-01-07 4:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 15:03 [PATCH] Discuss a couple common errors in kernel-doc usage Robert P. J. Day
2007-01-07 4:00 ` Randy Dunlap [this message]
2007-01-07 11:36 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070106200045.43683769.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.