From: Pavel Machek <pavel@ucw.cz>
To: Zhang Rui <rui.zhang@intel.com>
Cc: lenb@kernel.org, "linux-acpi@vger" <linux-acpi@vger.kernel.org>,
linux-pm@osdl.org
Subject: Re: [linux-pm] [PATCH 6/6] [-mm]: ACPI: duplicate ACPI "info" attribute in sysfs
Date: Sun, 7 Jan 2007 16:39:40 +0100 [thread overview]
Message-ID: <20070107153940.GA23879@elf.ucw.cz> (raw)
In-Reply-To: <1168083333.5619.40.camel@localhost.localdomain>
Hi!
>
> /* --------------------------------------------------------------------------
> + FS Interface (/sys)
> + -------------------------------------------------------------------------- */
> +extern struct subsystem acpi_subsys;
> +
> +static ssize_t info_show(struct subsystem *subsys, char *buf)
> +{
> + return sprintf(buf, "version: %x\n", ACPI_CA_VERSION);
> +}
One value per file... so it should omit "version: " string at the very least.
Plus I do not think we should have this file at all. ACPI is pretty
much in sync with kernel these days, and we do not have
/sys/scsi/scsi_core version nor /sys/vm/vm_internals_version etc.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-01-07 15:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-06 11:35 [PATCH 6/6] [-mm]: ACPI: duplicate ACPI "info" attribute in sysfs Zhang Rui
2007-01-06 21:36 ` David Brownell
2007-01-07 15:39 ` Pavel Machek [this message]
2007-01-21 5:50 ` [PATCH 3/3] [-mm]: ACPI: add ACPICA version " Zhang Rui
2007-01-25 2:42 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070107153940.GA23879@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@osdl.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.