From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] ruminations on kernel.h
Date: Sun, 07 Jan 2007 23:18:24 +0000 [thread overview]
Message-ID: <20070107231824.GS24620@parisc-linux.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0701071524240.14075@localhost.localdomain>
On Sun, Jan 07, 2007 at 03:55:11PM -0500, Robert P. J. Day wrote:
> On Sun, 7 Jan 2007, Matthew Wilcox wrote:
> > Well, kernel.h really is misc.h or util.h ;-)
>
> but, actually, it isn't. as i mentioned, there's *plenty* in there
> that really *does* seem to belong in other, more appropriate files.
> having all that stuff dumped in kernel.h just makes it that much
> harder to make an educated guess as to where to find things like
> macros and function declarations and the like.
By all means move stuff that seems more appropriate elsewhere.
My point was to *not* create a misc.h or util.h
> as another example, the function declarations for the
> simple_strto[u]l[l] routines are in kernel.h, but their
> implementations are in lib/vsprintf.c. if i was looking for that
> stuff, i would never have guessed that.
I'd suggest <linux/string.h> would be a better place for those.
> and there's lots more where that came from.
Of course. There's an almost infinite amount of cruft to deal with,
that's why there's this janitor list ...
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2007-01-07 23:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-07 20:24 [KJ] ruminations on kernel.h Robert P. J. Day
2007-01-07 20:47 ` Matthew Wilcox
2007-01-07 20:55 ` Robert P. J. Day
2007-01-07 23:18 ` Matthew Wilcox [this message]
2007-01-08 2:21 ` Ahmed S. Darwish
2007-01-08 3:07 ` Paul Bonser
2007-01-08 7:09 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070107231824.GS24620@parisc-linux.org \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.