From: Arnd Bergmann <arnd@arndb.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Kyle McMartin <kyle@parisc-linux.org>,
Christoph Hellwig <hch@infradead.org>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org, parisc-linux@lists.parisc-linux.org
Subject: Re: [PATCH] Common compat_sys_sysinfo (v2)
Date: Mon, 8 Jan 2007 06:54:26 +0100 [thread overview]
Message-ID: <200701080654.27100.arnd@arndb.de> (raw)
In-Reply-To: <20070108104347.83a004aa.sfr@canb.auug.org.au>
On Monday 08 January 2007 00:43, Stephen Rothwell wrote:
> > +asmlinkage long sys_sysinfo(struct sysinfo __user *info)
> > +{
> > + struct sysinfo val;
> > +
> > + do_sysinfo(&val);
> >
> > - out:
> > if (copy_to_user(info, &val, sizeof(struct sysinfo)))
> > return -EFAULT;
>
> People have complined before that this adds a whole stack frame to the
> "normal" syscall path. Personally I don't care, but it has been
> mentioned.
It might be a concern for something like 'read' which is called frequently
and in strange ways, but for 'sysinfo' this really should not matter.
Arnd <><
next prev parent reply other threads:[~2007-01-08 7:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-07 14:48 [PATCH] Common compat_sys_sysinfo Kyle McMartin
2007-01-07 15:13 ` [parisc-linux] " Christoph Hellwig
2007-01-07 15:13 ` Christoph Hellwig
2007-01-07 15:18 ` [parisc-linux] " Matthew Wilcox
2007-01-07 15:18 ` Matthew Wilcox
[not found] ` <119aab440701071422x2041a7b9lf5361c15a001d954@mail.gmail.com>
2007-01-07 22:31 ` [parisc-linux] " Matthew Wilcox
[not found] ` <20070107223130.GR24620@parisc-linux.org>
2007-01-07 23:27 ` Randolph Chung
[not found] ` <45A181E2.9020609@tausq.org>
2007-01-07 23:39 ` Matthew Wilcox
[not found] ` <20070107233931.GT24620@parisc-linux.org>
2007-01-08 1:48 ` Randolph Chung
2007-01-07 15:22 ` Kyle McMartin
2007-01-07 15:22 ` Kyle McMartin
2007-01-07 15:40 ` [parisc-linux] [PATCH] Common compat_sys_sysinfo (v2) Kyle McMartin
2007-01-07 15:40 ` Kyle McMartin
2007-01-07 23:43 ` [parisc-linux] " Stephen Rothwell
2007-01-07 23:43 ` Stephen Rothwell
2007-01-08 5:54 ` Arnd Bergmann [this message]
2007-01-08 7:29 ` Stephen Rothwell
2007-01-08 7:29 ` [parisc-linux] " Stephen Rothwell
2007-01-08 5:54 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701080654.27100.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=kyle@parisc-linux.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=parisc-linux@lists.parisc-linux.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.