From: Vivek Goyal <vgoyal@in.ibm.com>
To: linux kernel mailing list <linux-kernel@vger.kernel.org>
Cc: Fastboot mailing list <fastboot@lists.osdl.org>,
Morton Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@muc.de>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH 2/4] make initkmem_list3 non init data to fix modpost warning
Date: Mon, 8 Jan 2007 13:41:04 +0530 [thread overview]
Message-ID: <20070108081104.GD7889@in.ibm.com> (raw)
o MODPOST generates warning for i386 if kernel is compiled with
CONFIG_RELOCATABLE=y
WARNING: vmlinux - Section mismatch: reference to .init.data:initkmem_list3 from .text between 'set_up_list3s' (at offset 0xc01536d9) and 's_start'
o I don't know the code well but looks like this is a bug. initkmem_list3
is of type __initdata, and it is accessed by non init functions.
kmem_cache_create()
setup_cpu_cache()
set_up_list3s()
{
Accesses initkmem_list3[]
}
o Somebody who knows this code well needs to review and ack.
Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
---
mm/slab.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/slab.c~make-initkmem_list3-non-init mm/slab.c
--- linux-2.6.20-rc2-mm1-reloc/mm/slab.c~make-initkmem_list3-non-init 2007-01-04 16:51:02.000000000 +0530
+++ linux-2.6.20-rc2-mm1-reloc-root/mm/slab.c 2007-01-04 16:51:02.000000000 +0530
@@ -305,7 +305,7 @@ struct kmem_list3 {
* Need this for bootstrapping a per node allocator.
*/
#define NUM_INIT_LISTS (2 * MAX_NUMNODES + 1)
-struct kmem_list3 __initdata initkmem_list3[NUM_INIT_LISTS];
+struct kmem_list3 initkmem_list3[NUM_INIT_LISTS];
#define CACHE_CACHE 0
#define SIZE_AC 1
#define SIZE_L3 (1 + MAX_NUMNODES)
_
next reply other threads:[~2007-01-08 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 8:11 Vivek Goyal [this message]
2007-01-08 23:00 ` [PATCH 2/4] make initkmem_list3 non init data to fix modpost warning Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070108081104.GD7889@in.ibm.com \
--to=vgoyal@in.ibm.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.