From: Jarek Poplawski <jarkao2@o2.pl>
To: Paul Moore <paul.moore@hp.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] INET: fix incorrect "inet_sock->is_icsk" assignment
Date: Mon, 8 Jan 2007 14:25:48 +0100 [thread overview]
Message-ID: <20070108132548.GA2324@ff.dom.local> (raw)
In-Reply-To: <20070104200437.008980288@hp.com>
On 04-01-2007 21:04, Paul Moore wrote:
...
> +++ net-2.6.20_bugfix_2/net/ipv4/af_inet.c
> @@ -305,7 +305,7 @@ lookup_protocol:
> sk->sk_reuse = 1;
>
> inet = inet_sk(sk);
> - inet->is_icsk = INET_PROTOSW_ICSK & answer_flags;
> + inet->is_icsk = (INET_PROTOSW_ICSK & answer_flags) == INET_PROTOSW_ICSK;
Isn't this more readable like this?:
inet->is_icsk = (INET_PROTOSW_ICSK & answer_flags) != 0;
Regards,
Jarek P.
next prev parent reply other threads:[~2007-01-08 13:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070104200430.149943972@hp.com>
2007-01-04 20:04 ` [PATCH] INET: fix incorrect "inet_sock->is_icsk" assignment Paul Moore
2007-01-05 0:57 ` David Miller
2007-01-05 2:32 ` Arnaldo Carvalho de Melo
2007-01-05 5:42 ` David Miller
2007-01-08 13:25 ` Jarek Poplawski [this message]
2007-01-08 14:47 ` Paul Moore
2007-01-09 8:43 ` Jarek Poplawski
2007-01-09 14:26 ` Paul Moore
2007-01-09 14:52 ` Arnaldo Carvalho de Melo
2007-01-10 10:01 ` Jarek Poplawski
2007-01-10 13:13 ` Paul Moore
2007-01-10 13:31 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070108132548.GA2324@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.