All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] kernel patch for adm1029 support
Date: Mon, 08 Jan 2007 14:16:08 +0000	[thread overview]
Message-ID: <20070108151608.70968e67.khali@linux-fr.org> (raw)
In-Reply-To: <459FFAC8.40306@geomatys.fr>

Hi Corentin,

On Sat, 06 Jan 2007 20:38:48 +0100, corentin.labbe wrote:
> Hello
> 
> This is my patchs for adding ADM1029 support in kernel.

Once again I had to edit the patch by hand before I was able to apply
it. Either it wasn't properly generated in the first place, or your
mailer is trashing it. Please test next time.

It also lacks your Signed-off-by line, as described in
Documentation/SubmittingPatches, section 11. This is mandatory.

Other than that, I am fine with your code, with the exception of minor
whitespace problems, which I can fix myself as I submit the patch
upstream. Thanks for your contribution!

-- 
Jean Delvare


  reply	other threads:[~2007-01-08 14:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-06 19:38 [lm-sensors] kernel patch for adm1029 support corentin.labbe
2007-01-08 14:16 ` Jean Delvare [this message]
2007-01-09 18:40 ` corentin.labbe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070108151608.70968e67.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.