From: Ralf Baechle <ralf@linux-mips.org>
To: Davy Chan <chandave-linux-mips@wiasia.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] pnx8550: Fix broken write_config_byte() function in arch/mips/pci/ops-pnx8550.c
Date: Mon, 8 Jan 2007 15:26:27 +0000 [thread overview]
Message-ID: <20070108152627.GD28691@linux-mips.org> (raw)
In-Reply-To: <20070105135646.D14007@wiasia.com>
On Fri, Jan 05, 2007 at 01:56:46PM +0800, Davy Chan wrote:
> There's a serious typo in the function:
> arch/mips/pci/ops-pnx8550.c:write_config_byte()
>
> The parameter passed to the function config_access() is PCI_CMD_CONFIG_READ
> instead of PCI_CMD_CONFIG_WRITE. This renders any attempts to write
> a single byte to the PCI configuration registers useless.
>
> This problem does not exist for write_config_word() nor write_config_dword().
>
> This problem has been there since kernel v2.6.17 and is still there
> as of kernel v2.6.19.1.
The bug exists even in 2.6.16 which is the oldest -stable branch I'm still
maintaining on linux-mips.org.
Patch applied. Standard rant, please add a Signed-off-by: line. See
Documentation/SubmittingPatches for what this is about.
Ralf
prev parent reply other threads:[~2007-01-08 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-05 5:56 [PATCH] pnx8550: Fix broken write_config_byte() function in arch/mips/pci/ops-pnx8550.c Davy Chan
2007-01-08 15:26 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070108152627.GD28691@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=chandave-linux-mips@wiasia.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.