All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] generic chip support for sensors
Date: Mon, 08 Jan 2007 17:39:45 +0000	[thread overview]
Message-ID: <20070108183945.84115dfc.khali@linux-fr.org> (raw)
In-Reply-To: <20061210000539.1f2f2bbd@ws01.atreidis.nl.eu.org>

Hi Mark,

On Sun, 7 Jan 2007 14:36:26 -0500, Mark M. Hoffman wrote:
> Hi Bob:
> 
> * Bob Schl?rmann <bob2 at dsv.nl> [2006-12-24 18:29:39 +0100]:
> > The following patch changes all of the lib/chips.c entries and any function
> > that uses sensors_chip_feature. Most of the conversion was done through a
> > perl script, so if you don't agree with the syntax it'll be easy to change.
> > 
> > It's a diff against current svn.
> 
> Very nice, thanks for doing this.  I have some minor requests though...
> 
> * please CC the lm-sensors list with all patches
> * always prepare patches with lm-sensors as CWD, even if it only touches lib
> * attach patches as plain text instead of base64 if possible
> 
> I fixed up your patch so it applies to latest SVN (adm1029 support was added
> since then), and IMO we should apply this prior to releasing 2.10.2 even.
> 
> BTW: A binary diff between SVN and patched revisions of lib/chips.ao,
> lib/proc.ao, and lib/access.ao comes up clean.  That is proof enough for me
> that this transformation was done correctly.
> 
> Thanks again Bob.  Here's the revised patch; comments anyone?

If you feel like it is safe and can be merged, fine with me, just apply
that patch. After that, the repository is frozen and the pre-release
tests can begin. I'd really like to stick to the schedule.

-- 
Jean Delvare


      parent reply	other threads:[~2007-01-08 17:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-09 23:05 [lm-sensors] generic chip support for sensors Bob Schlärmann
2006-12-19 13:11 ` Mark M. Hoffman
2006-12-19 13:22 ` Mark M. Hoffman
2006-12-21 12:12 ` Mark M. Hoffman
2007-01-07 19:36 ` Mark M. Hoffman
2007-01-08 17:39 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070108183945.84115dfc.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.