Re: [patch] paravirt: disable Kbuild option for now

[Ingo Molnar <mingo@elte.hu>]

* Rusty Russell <rusty@rustcorp.com.au> wrote:

> > Andrew, we need to fix this before v2.6.20 is released. Simplest 
> > upstream fix is to just disable the CONFIG_PARAVIRT Kbuild option, 
> > as per the patch below. Rusty's unexport patch is promising in many 
> > ways, but it's v2.6.21 stuff IMO.
> 
> No.  Just drop the whole "don't export paravirt_ops" idea, and we'll 
> work on that for 2.6.21.
> 
> I don't see a problem with exporting paravirt_ops, [...]

I do see a problem with it: it's been poorly done /because/ nothing 
in-kernel uses it. We can fix it for 2.6.21, but lets disable it for 
2.6.20 - or make the export _GPL as per the patch below. We can enable 
it no problem. Or if that doesnt happen i'm strongly NACK-ing the whole 
paravirt subsystem in its current form.

	Ingo

---------------->
From: Ingo Molnar <mingo@elte.hu>
Subject: [patch] paravirt: mark the export GPL

the paravirt subsystem is still in flux so all exports from it are 
definitely internal use only. The APIs around this /will/ change.

Signed-off-by: Ingo Molnar <mingo@elte.hu>

Index: linux/arch/i386/kernel/paravirt.c
===================================================================
--- linux.orig/arch/i386/kernel/paravirt.c
+++ linux/arch/i386/kernel/paravirt.c
@@ -566,4 +566,4 @@ struct paravirt_ops paravirt_ops = {
 	.irq_enable_sysexit = native_irq_enable_sysexit,
 	.iret = native_iret,
 };
-EXPORT_SYMBOL(paravirt_ops);
+EXPORT_SYMBOL_GPL(paravirt_ops);