All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: balrogg@gmail.com
Cc: Linux-OMAP <linux-omap-open-source@linux.omap.com>
Subject: Re: [PATCH] Make omap_bl build again after API change.
Date: Tue, 9 Jan 2007 15:32:45 -0800	[thread overview]
Message-ID: <20070109233244.GQ7384@atomide.com> (raw)
In-Reply-To: <1167956787968-git-send-email-balrog@zabor.org>

* Andrzej Zaborowski <balrog@zabor.org> [070104 15:26]:
> [Oops, I sent this to Dirk eariler and forgot to CC the list.]
> Make omap_bl build again after API change.
> 
> Breakage spotted by Dirk Behme.
> Also remove comment about API glitch which has just been fixed.
> 
> Signed-off-by: Andrzej Zaborowski <balrog@zabor.org>
> ---
>  drivers/video/backlight/omap_bl.c |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/video/backlight/omap_bl.c b/drivers/video/backlight/omap_bl.c
> index 22189b1..3b57b27 100644
> --- a/drivers/video/backlight/omap_bl.c
> +++ b/drivers/video/backlight/omap_bl.c
> @@ -152,12 +152,8 @@ static int omapbl_probe(struct platform_
>  	if (unlikely(!bl))
>  		return -ENOMEM;
>  
> -	/* REVISIT backlight API glitch:  we can't associate the
> -	 * class device with "pdev" ... probably pass &pdev->dev
> -	 * instead of a string.
> -	 */
> -
> -	dev = backlight_device_register("omap-bl", bl, &omapbl_data);
> +	dev = backlight_device_register("omap-bl", &pdev->dev,
> +			bl, &omapbl_data);
>  	if (IS_ERR(dev)) {
>  		kfree(bl);
>  		return PTR_ERR(dev);

Pushing today.

Tony

      reply	other threads:[~2007-01-09 23:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-05  0:26 [PATCH] Make omap_bl build again after API change Andrzej Zaborowski
2007-01-09 23:32 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070109233244.GQ7384@atomide.com \
    --to=tony@atomide.com \
    --cc=balrogg@gmail.com \
    --cc=linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.