All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Chinner <dgc@sgi.com>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: David Chinner <dgc@sgi.com>,
	Christoph Hellwig <hch@infradead.org>,
	xfs-dev@sgi.com, xfs@oss.sgi.com
Subject: Re: Review: fix mapping invalidation callouts
Date: Wed, 10 Jan 2007 11:10:28 +1100	[thread overview]
Message-ID: <20070110001028.GO33919298@melbourne.sgi.com> (raw)
In-Reply-To: <45A38332.40506@sgi.com>

On Tue, Jan 09, 2007 at 11:57:38AM +0000, Lachlan McIlroy wrote:
> 
> This patch fixes fs_tosspages() and fs_flushinval_pages() but will a
> call to fs_flush_pages() with flags including B_INVAL work correctly?

By definition fs_flush_pages() only flushes pages. If you need
to flush and invalidate pages, you use fs_flushinval_pages().

Passing B_INVAL to fs_flush_pages() is broken code.

> I can't see any code that passes B_INVAL into fs_flush_pages()

good ;)

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group

  reply	other threads:[~2007-01-10  0:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-08  4:03 Review: fix mapping invalidation callouts David Chinner
2007-01-08  9:09 ` Christoph Hellwig
2007-01-08 23:04   ` David Chinner
2007-01-09 11:57     ` Lachlan McIlroy
2007-01-10  0:10       ` David Chinner [this message]
2007-01-10  6:23 ` David Chinner
2007-01-10  8:39   ` Lachlan McIlroy
2007-01-11  6:49     ` David Chinner
2007-01-11  8:00       ` David Chinner
2007-01-11  8:01       ` David Chatterton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070110001028.GO33919298@melbourne.sgi.com \
    --to=dgc@sgi.com \
    --cc=hch@infradead.org \
    --cc=lachlan@sgi.com \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.