From: Magnus Damm <magnus@valinux.co.jp>
To: Ian Campbell <Ian.Campbell@XenSource.com>
Cc: Christoph Egger <Christoph.Egger@amd.com>,
xen-devel@lists.xensource.com, Magnus Damm <magnus@valinux.co.jp>,
Hiromichi Itou <ito@begi.net>
Subject: [PATCH] Fix parse_size_and_unit() breakage in xen-3.0.4-testing (kdump broken)
Date: Wed, 10 Jan 2007 17:42:15 +0900 [thread overview]
Message-ID: <20070110084215.13837.79290.sendpatchset@localhost> (raw)
Fix parse_size_and_unit() breakage in xen-3.0.4-testing (kdump broken)
Kdump has been broken since xen-3.0.4-testing.hg-13109.
Many thanks to Hiromichi Itou for tracking this down.
Signed-Off-By: Magnus Damm <magnus@valinux.co.jp>
---
Applies to xen-3.0.4-testing-13130.
--- 0001/xen/common/lib.c
+++ work/xen/common/lib.c 2007-01-10 11:18:38.000000000 +0900
@@ -442,7 +442,7 @@ s64 __moddi3(s64 a, s64 b)
unsigned long long parse_size_and_unit(const char *s, const char **ps)
{
unsigned long long ret;
- const char *s1;
+ const char *s1 = NULL;
ret = simple_strtoull(s, &s1, 0);
@@ -454,7 +454,7 @@ unsigned long long parse_size_and_unit(c
case 'K': case 'k':
ret <<= 10;
case 'B': case 'b':
- s++;
+ s1++;
break;
default:
ret <<= 10; /* default to kB */
next reply other threads:[~2007-01-10 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-10 8:42 Magnus Damm [this message]
2007-01-10 9:24 ` [PATCH] Fix parse_size_and_unit() breakage in xen-3.0.4-testing (kdump broken) Ian Campbell
2007-01-11 1:25 ` Magnus Damm
2007-01-10 11:35 ` Steven Hand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070110084215.13837.79290.sendpatchset@localhost \
--to=magnus@valinux.co.jp \
--cc=Christoph.Egger@amd.com \
--cc=Ian.Campbell@XenSource.com \
--cc=ito@begi.net \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.