All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Oeser <netdev@axxeo.de>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 3/3] chelsio: more rx speedup
Date: Wed, 10 Jan 2007 09:30:12 +0100	[thread overview]
Message-ID: <200701100930.12798.netdev@axxeo.de> (raw)
In-Reply-To: <20070109102647.05d92861@freekitty>

Stephen Hemminger schrieb:
> On Tue, 9 Jan 2007 09:42:03 +0100
> Ingo Oeser <netdev@axxeo.de> wrote:
> > Stephen Hemminger schrieb:
> > > --- netdev-2.6.orig/drivers/net/chelsio/sge.c
> > > +++ netdev-2.6/drivers/net/chelsio/sge.c
> > Please use NET_IP_ALIGN here:
> 
> Wrong, NET_IP_ALIGN is intended to deal with platforms where alignment of DMA is more
> important of alignment of structures.  Therefore if data is copied, it should
> always be 2.

Ah! Thanks for clearing this up. These magic numbers always make my head spin
so I tried to come up with sth. useful :-)

If this pattern is present in many drivers, we might have a define or helper for this.


Regards

Ingo Oeser

  parent reply	other threads:[~2007-01-10  8:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-15 19:07 [PATCH 0/3] chelsio driver changes Stephen Hemminger
2006-12-15 19:07 ` [PATCH 1/3] chelsio: fix error path Stephen Hemminger
2006-12-15 19:07 ` [PATCH 2/3] chelsio: NAPI speed improvement Stephen Hemminger
2006-12-15 19:07 ` [PATCH 3/3] chelsio: more receive cleanup Stephen Hemminger
2006-12-15 20:10   ` Francois Romieu
2006-12-15 22:55     ` Stephen Hemminger
2006-12-16  0:26       ` Francois Romieu
2006-12-16  1:28         ` Stephen Hemminger
2006-12-26 21:16 ` [PATCH 0/3] chelsio driver changes Jeff Garzik
2007-01-08 19:24   ` [PATCH 1/3] chelsio: error path fix Stephen Hemminger
     [not found]     ` <20070108112524.730e89f0@dxpl.pdx.osdl.net>
2007-01-08 19:26       ` [PATCH 3/3] chelsio: more rx speedup Stephen Hemminger
2007-01-09  8:42         ` Ingo Oeser
2007-01-09 18:26           ` Stephen Hemminger
2007-01-10  2:08             ` Divy Le Ray
2007-01-10  8:34               ` Ingo Oeser
2007-01-10  8:30             ` Ingo Oeser [this message]
2007-01-19  3:05         ` Jeff Garzik
2007-01-08 19:26     ` [PATCH 2/3] chelsio: NAPI speed improvement Stephen Hemminger
2007-01-19  3:05       ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200701100930.12798.netdev@axxeo.de \
    --to=netdev@axxeo.de \
    --cc=jgarzik@pobox.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.