From mboxrd@z Thu Jan  1 00:00:00 1970
From: Horms <horms@verge.net.au>
Subject: Re: [PATCH] kexec/kdump: fix grammar in comment
Date: Thu, 11 Jan 2007 12:35:34 +0900
Message-ID: <20070111033533.GA8726@verge.net.au>
References: <20070110080337.GA4687@verge.net.au>
	<1168421358.24570.25.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <1168421358.24570.25.camel@localhost.localdomain>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@xensource.com>
Cc: xen-devel <xen-devel@lists.xensource.com>, Magnus Damm <magnus.damm@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On Wed, Jan 10, 2007 at 09:29:18AM +0000, Ian Campbell wrote:
> On Wed, 2007-01-10 at 17:03 +0900, Horms wrote:
> > Fix the grammar in the comment that features in
> > xen_machine_kexec_setup_resources(). The current
> > edition is a bit odd.
> 
> What I was trying to say is that we allow a possible memory leak because
> the failure is unexpected and the amount is small, your version doesn't
> really convey that information.
> 
> I've changed it to:
> 
>       * It isn't possible to free xen_phys_cpus this early in the 
>       * boot. Failure at this stage is unexpected and the
>       * amount of memory is small therefore we tolerate the
>       * potential leak.

Thanks.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/