From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: linux-ide@vger.kernel.org, paulus@samba.org
Subject: Re: [PATCH 2/2] drivers/ata: export some static functions in libata-core.c
Date: Thu, 11 Jan 2007 14:05:56 +0100 [thread overview]
Message-ID: <200701111405.56575.arnd@arndb.de> (raw)
In-Reply-To: <200701110928.l0B9SUri015056@toshiba.co.jp>
On Thursday 11 January 2007 10:30, Akira Iguchi wrote:
> >Exporting new symbols needs some explanation here about why they
> >should now be global for ata_scc while the existing drivers
> >did not need them. Since the patch otherwise only moves stuff
> >around as needed, I assume it's good.
>
> I thought it was better to use common functions as far as possible.
> But if it is preferable to copy them in ata_scc.c, I will do so.
To clarify my words here:
It is definitely better to use common functions or to modify the common
code rather than copy it.
This particular patch (2/2) only moves code around, so what I meant is
that I'm confident that it does not introduce bugs.
Arnd <><
next prev parent reply other threads:[~2007-01-11 13:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200701110853.l0B8rtGK009404@toshiba.co.jp>
2007-01-11 9:08 ` [PATCH 2/2] drivers/ata: export some static functions in libata-core.c Arnd Bergmann
2007-01-11 9:30 ` Akira Iguchi
2007-01-11 9:30 ` Akira Iguchi
2007-01-11 13:05 ` Arnd Bergmann [this message]
2007-01-11 17:17 ` Linas Vepstas
2007-01-11 17:17 ` Linas Vepstas
2007-01-12 0:48 ` Akira Iguchi
2007-01-12 0:48 ` Akira Iguchi
2007-01-12 0:55 ` Benjamin Herrenschmidt
2007-01-12 0:55 ` Benjamin Herrenschmidt
[not found] ` <200701110928.l0B9SUUv028654@toshiba.co.jp>
2007-01-11 21:37 ` Benjamin Herrenschmidt
2007-01-11 21:37 ` Benjamin Herrenschmidt
2007-01-11 8:56 Akira Iguchi
-- strict thread matches above, loose matches on Subject: below --
2007-01-11 8:56 Akira Iguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701111405.56575.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.