From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Christoph Egger" <Christoph.Egger@amd.com>
Subject: Re: [PATCH] Cleanup asm-x86/guest_access.h
Date: Fri, 12 Jan 2007 14:43:32 +0100
Message-ID: <200701121443.33138.Christoph.Egger@amd.com>
References: <C1CD3F8A.789C%keir@xensource.com>
Mime-Version: 1.0
Content-Type: text/plain;
 charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C1CD3F8A.789C%keir@xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: Keir Fraser <keir@xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Friday 12 January 2007 14:37, Keir Fraser wrote:
> On 12/1/07 12:01, "Petersson, Mats" <Mats.Petersson@amd.com> wrote:
> >> copy_{to,from}_user() and copy_{to,from}_user_hvm() expect a non-const
> >> argument as the first argument. So I remove the consts from
> >> the initializer.
> >> I replace typeof with __typeof__, which is always available
> >> in gcc - it is
> >> not, when the -ansi option is used.
> >
> > And is it expected that Xen will EVER be compiled with -ansi? I think
> > there's enough gcc-isms in other places that this will never happen -
> > not that it really makes any difference, I'm just curious if anyone
> > "cares"...
>
> Yes, I'm going to take the const cleanups but bin the __typeof__ changes.

Do you also take the small bugfix in the __copy_field_from_guest() function
at the very bottom in my patch ?