All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de>
To: git@vger.kernel.org
Cc: Junio C Hamano <junkio@cox.net>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] gitk errors out if launched in a subdirectory
Date: Fri, 12 Jan 2007 18:43:40 +0100	[thread overview]
Message-ID: <20070112174340.GA6262@xp.machine.xx> (raw)
In-Reply-To: <20070109143019.GA24688@xp.machine.xx>

Is there something obviously wrong with this patch? It is the second
time I send this (or a slight variant; last time I even removed the
enviroment checking) and nobody answered.

Please say so if it is NAKed.

-Peter


On Tue, Jan 09, 2007 at 03:30:19PM +0100, Peter Baumann wrote:
> Make gitk use git-rev-parse --git-dir to find the repository.
> 
> Signed-off-by: Peter Baumann <siprbaum@stud.informatik.uni-erlangen.de>
> ---
>  gitk |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/gitk b/gitk
> index 3dabc69..ec4f1bd 100755
> --- a/gitk
> +++ b/gitk
> @@ -12,7 +12,7 @@ proc gitdir {} {
>      if {[info exists env(GIT_DIR)]} {
>  	return $env(GIT_DIR)
>      } else {
> -	return ".git"
> +	return [exec git rev-parse --git-dir]
>      }
>  }
>  
> -- 
> 1.4.4.2
> 

  reply	other threads:[~2007-01-12 17:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-09 14:30 [PATCH] gitk errors out if launched in a subdirectory Peter Baumann
2007-01-12 17:43 ` Peter Baumann [this message]
2007-01-12 17:59   ` Junio C Hamano
2007-01-13  3:13   ` Paul Mackerras
2007-01-13 16:10     ` Peter Baumann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070112174340.GA6262@xp.machine.xx \
    --to=siprbaum@stud.informatik.uni-erlangen.de \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.