All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Linux Kernel List <linux-kernel@vger.kernel.org>,
	jffs-dev@axis.com, dwmw2@infradead.org
Cc: Al Viro <viro@zeniv.linux.org.uk>
Subject: [2.6 patch] fix the JFFS2_FS_DEBUG=2 compilation
Date: Sat, 13 Jan 2007 11:51:22 +0100	[thread overview]
Message-ID: <20070113105122.GL7469@stusta.de> (raw)
In-Reply-To: <20070112210537.GA24451@flint.arm.linux.org.uk>

On Fri, Jan 12, 2007 at 09:05:37PM +0000, Russell King wrote:
> The following configuration:
> 
> CONFIG_JFFS2_FS=y
> CONFIG_JFFS2_FS_DEBUG=2
> # CONFIG_JFFS2_FS_NAND is not set
> # CONFIG_JFFS2_FS_NOR_ECC is not set
> # CONFIG_JFFS2_COMPRESSION_OPTIONS is not set
> CONFIG_JFFS2_ZLIB=y
> CONFIG_JFFS2_RTIME=y
> # CONFIG_JFFS2_RUBIN is not set
> 
> results in these build errors:
> 
> fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dirent':
> fs/jffs2/malloc.c:126: error: dereferencing pointer to incomplete type
> fs/jffs2/malloc.c: In function 'jffs2_free_full_dirent':
> fs/jffs2/malloc.c:132: error: dereferencing pointer to incomplete type
> fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dnode':
> fs/jffs2/malloc.c:140: error: dereferencing pointer to incomplete type
> fs/jffs2/malloc.c: In function 'jffs2_free_full_dnode':
> fs/jffs2/malloc.c:146: error: dereferencing pointer to incomplete type
> fs/jffs2/malloc.c: In function 'jffs2_alloc_raw_dirent':
> fs/jffs2/malloc.c:154: error: dereferencing pointer to incomplete type
> 
> ... etc ...

Thanks for the report, patch below.

cu
Adrian


<--  snip  -->


This patch fixes the following CONFIG_JFFS2_FS_DEBUG=2 compile 
breakage introduced by commit 914e26379decf1fd984b22e51fd2e4209b7a7f1b:

<--  snip  -->

...
fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dirent':
fs/jffs2/malloc.c:126: error: dereferencing pointer to incomplete type
fs/jffs2/malloc.c: In function 'jffs2_free_full_dirent':
fs/jffs2/malloc.c:132: error: dereferencing pointer to incomplete type
fs/jffs2/malloc.c: In function 'jffs2_alloc_full_dnode':
fs/jffs2/malloc.c:140: error: dereferencing pointer to incomplete type
fs/jffs2/malloc.c: In function 'jffs2_free_full_dnode':
fs/jffs2/malloc.c:146: error: dereferencing pointer to incomplete type
fs/jffs2/malloc.c: In function 'jffs2_alloc_raw_dirent':
fs/jffs2/malloc.c:154: error: dereferencing pointer to incomplete type
...

<--  snip  -->

Signed-off-by: Adrian Bunk <bunk@stusta.de>

commit 3a7722fc440d5214a718bc4b90b7691c04a1af67
Author: Adrian Bunk <bunk@stusta.de>
Date:   Sat Jan 13 11:50:44 2007 +0100

    sadf

diff --git a/fs/jffs2/debug.h b/fs/jffs2/debug.h
index 3daf3bc..f89c85d 100644
--- a/fs/jffs2/debug.h
+++ b/fs/jffs2/debug.h
@@ -13,6 +13,7 @@
 #ifndef _JFFS2_DEBUG_H_
 #define _JFFS2_DEBUG_H_
 
+#include <linux/sched.h>
 
 #ifndef CONFIG_JFFS2_FS_DEBUG
 #define CONFIG_JFFS2_FS_DEBUG 0


  reply	other threads:[~2007-01-13 10:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-12 21:05 Build regression since 2.6.19-git7: jffs2 Russell King
2007-01-13 10:51 ` Adrian Bunk [this message]
2007-01-13 11:29   ` [2.6 patch] fix the JFFS2_FS_DEBUG=2 compilation David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070113105122.GL7469@stusta.de \
    --to=bunk@stusta.de \
    --cc=dwmw2@infradead.org \
    --cc=jffs-dev@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.