From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: jgarzik@pobox.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros
Date: Mon, 15 Jan 2007 09:16:02 +0200 [thread overview]
Message-ID: <20070115071602.GE3874@Ahmed> (raw)
In-Reply-To: <1168796241.3123.954.camel@laptopd505.fenrus.org>
On Sun, Jan 14, 2007 at 09:37:21AM -0800, Arjan van de Ven wrote:
> On Sun, 2007-01-14 at 19:24 +0200, Ahmed S. Darwish wrote:
> > Substitue intel_rng magic PCI IDs values used in the IDs table
> > with the macros defined in pci_ids.h
> >
> Hi,
>
>
> hmm this is actually the opposite direction than most of the kernel is
> heading in, mostly because the pci_ids.h file is a major maintenance
> pain.
>
> Afaik the current "rule" is: if a PCI ID is only used in one driver, use
> the numeric value and not (add) a symbolic constant.
I think you understood me wrong .. I haven't added new macros in pci_ids.h,
I've just used the macros already defined there like the PCI_VENDOR_ID_INTEL
and others.
--
Ahmed S. Darwish
http://darwish-07.blogspot.com
next prev parent reply other threads:[~2007-01-15 7:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-14 17:24 [PATCH 2.6.20-rc5] intel_rng: substitue magic PCI IDs with macros Ahmed S. Darwish
2007-01-14 17:37 ` Arjan van de Ven
2007-01-14 19:31 ` Dave Airlie
2007-01-14 23:07 ` Ahmed S. Darwish
2007-01-15 0:29 ` Greg KH
2007-01-15 7:16 ` Ahmed S. Darwish [this message]
2007-01-15 17:50 ` Ahmed S. Darwish
2007-01-15 0:29 ` Greg KH
2007-01-15 9:17 ` Ahmed S. Darwish
-- strict thread matches above, loose matches on Subject: below --
2007-01-15 20:38 Ahmed S. Darwish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070115071602.GE3874@Ahmed \
--to=darwish.07@gmail.com \
--cc=arjan@infradead.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.