All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stuart Brady <sdbrady@ntlworld.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Possible regression for Heathrow (PPC), with workaround
Date: Mon, 15 Jan 2007 18:37:54 +0000	[thread overview]
Message-ID: <20070115183754.GA9281@miranda.arrow> (raw)

Hi,

I've noticed a possible regression involving the Heathrow (PPC) machine,
caused by the PCI IRQ sharing patch commited on 2006-09-24.

The Debian Sarge (3.1) installer does not appear to run correctly since
that commit, due to lost interrupts.

(FWIW, I was following http://overselfresearch.com/kb/qemu.html)

Here is a workaround for the issue:

diff -u -r1.3 grackle_pci.c
--- hw/grackle_pci.c	24 Sep 2006 17:01:44 -0000	1.3
+++ hw/grackle_pci.c	15 Jan 2007 18:31:47 -0000
@@ -77,12 +77,14 @@
 /* Don't know if this matches real hardware, but it agrees with OHW.  */
 static int pci_grackle_map_irq(PCIDevice *pci_dev, int irq_num)
 {
-    return (irq_num + (pci_dev->devfn >> 3)) & 3;
+    /* XXX: Workaround */
+    return pci_dev->config[PCI_INTERRUPT_LINE];
 }
 
 static void pci_grackle_set_irq(void *pic, int irq_num, int level)
 {
-    heathrow_pic_set_irq(pic, irq_num + 8, level);
+    /* XXX: Workaround */
+    heathrow_pic_set_irq(pic, irq_num, level);
 }
 
 PCIBus *pci_grackle_init(uint32_t base, void *pic)
 
Cheers,
-- 
Stuart Brady

                 reply	other threads:[~2007-01-15 18:38 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070115183754.GA9281@miranda.arrow \
    --to=sdbrady@ntlworld.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.