From: Vojtech Pavlik <vojtech@suse.cz>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Jiri Kosina <jikos@jikos.cz>, Simon Budig <simon@budig.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator)
Date: Mon, 15 Jan 2007 19:56:56 +0100 [thread overview]
Message-ID: <20070115185656.GB7161@suse.cz> (raw)
In-Reply-To: <1168886290.31200.15.camel@violet>
On Mon, Jan 15, 2007 at 07:38:10PM +0100, Marcel Holtmann wrote:
> Hi Vojtech,
>
> > > No, it didn't disappear, it was just moved to include/linux/hid-debug.h.
> >
> > Do you think that makes sense? It's code, not a header file.
> >
> > > Should I wait for an updated patch that uses hid-debug.h again?
>
> actually that code shouldn't be in a header file at all. It should be
> drivers/hid/hid-debug.c and the Makefile should compile it conditionally
> depending on a Kconfig option.
Agreed. It was a .h file just because of me being lazy.
--
Vojtech Pavlik
Director SuSE Labs
next prev parent reply other threads:[~2007-01-15 18:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-14 23:11 [PATCH 2.6.19] USB HID: proper LED-mapping (support for SpaceNavigator) Simon Budig
2007-01-15 8:42 ` Jiri Kosina
2007-01-15 16:25 ` Simon Budig
2007-01-15 16:44 ` Jiri Kosina
2007-01-15 17:32 ` Simon Budig
2007-01-15 21:14 ` Jiri Kosina
2007-01-15 22:55 ` Simon Budig
2007-01-15 18:32 ` Vojtech Pavlik
2007-01-15 18:38 ` Marcel Holtmann
2007-01-15 18:56 ` Vojtech Pavlik [this message]
2007-01-15 16:28 ` [PATCH 2.6.20-rc5] " Simon Budig
2007-01-15 17:34 ` Simon Budig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070115185656.GB7161@suse.cz \
--to=vojtech@suse.cz \
--cc=jikos@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=simon@budig.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.