All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <zeisberg@informatik.uni-freiburg.de>
To: git@vger.kernel.org
Subject: [PATCH RFC] new config option remote.<name>.pushexec
Date: Tue, 16 Jan 2007 16:02:59 +0100	[thread overview]
Message-ID: <20070116150259.GA2439@cepheus> (raw)

git push --exec=... is fine, but having it to specify every time is
annoying.

This sets the default remote program for pushing to remote <name>.

Signed-off-by: Uwe Kleine-König <zeisberg@informatik.uni-freiburg.de>
---

This has (still) a few short comings:

 a) compiler warning because execute has the type const char*.

 b) cmdline should overwrite remote.<name>.pushexec w/o the warning.

 c) the symmetric part for fetch is missing.

The idea should be clear.  Would a more complete patch be welcome?

Best regards
Uwe

 Documentation/config.txt |    4 ++++
 builtin-push.c           |    7 +++++++
 2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/Documentation/config.txt b/Documentation/config.txt
index faa17ba..667628a 100644
--- a/Documentation/config.txt
+++ b/Documentation/config.txt
@@ -351,6 +351,10 @@ remote.<name>.push::
 	The default set of "refspec" for gitlink:git-push[1]. See
 	gitlink:git-push[1].
 
+remote.<name>.pushexec::
+	The default program to execute on the remote side.  See
+	option \--exec of gitlink:git-push[1].
+
 repack.usedeltabaseoffset::
 	Allow gitlink:git-repack[1] to create packs that uses
 	delta-base offset.  Defaults to false.
diff --git a/builtin-push.c b/builtin-push.c
index 7a3d2bb..8ea5dea 100644
--- a/builtin-push.c
+++ b/builtin-push.c
@@ -157,6 +157,13 @@ static int get_remote_config(const char* key, const char* value)
 		else if (config_get_refspecs &&
 			 !strcmp(key + 7 + config_repo_len, ".push"))
 			add_refspec(xstrdup(value));
+		else if (!strcmp(key + 7 + config_repo_len, ".pushexec")) {
+			if (!execute) {
+				execute = xmalloc(strlen(value) + 8);
+				sprintf(execute, "--exec=%s", value);
+			} else
+				error("more than one pushexec given");
+		}
 	}
 	return 0;
 }
-- 
1.5.0.rc1.g581a


-- 
Uwe Kleine-König

http://www.google.com/search?q=5+choose+3

             reply	other threads:[~2007-01-16 15:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-16 15:02 Uwe Kleine-König [this message]
2007-01-16 15:16 ` [PATCH RFC] new config option remote.<name>.pushexec Johannes Schindelin
2007-01-16 16:26   ` Uwe Kleine-König
2007-01-16 17:37     ` How to merge FETCH_HEAD? Michael S. Tsirkin
2007-01-16 19:59       ` Shawn O. Pearce
2007-01-16 21:33         ` Michael S. Tsirkin
2007-01-16 21:36           ` Johannes Schindelin
2007-01-17  5:09             ` Michael S. Tsirkin
2007-01-17  6:14               ` Junio C Hamano
2007-01-17  6:33                 ` Michael S. Tsirkin
2007-01-16 20:15       ` Junio C Hamano
2007-01-16 20:08     ` [PATCH RFC] new config option remote.<name>.pushexec Shawn O. Pearce
2007-01-16 20:30       ` Johannes Schindelin
2007-01-17 16:44         ` Uwe Kleine-König
2007-01-17 17:32           ` Junio C Hamano
2007-01-18  7:17             ` Uwe Kleine-König
2007-01-25  4:45               ` [PATCH] make --upload-pack option to git-fetch configurable Uwe Kleine-König
2007-01-25  4:53                 ` Uwe Kleine-König
2007-01-16 16:27   ` [PATCH RFC] new config option remote.<name>.pushexec Brian Gernhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070116150259.GA2439@cepheus \
    --to=zeisberg@informatik.uni-freiburg.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.