From: Jens Axboe <jens.axboe@oracle.com>
To: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: JFS Discussion <jfs-discussion@lists.sourceforge.net>,
fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging
Date: Thu, 18 Jan 2007 10:46:53 +1100 [thread overview]
Message-ID: <20070117234653.GI3508@kernel.dk> (raw)
In-Reply-To: <1169077157.10560.16.camel@kleikamp.austin.ibm.com>
On Wed, Jan 17 2007, Dave Kleikamp wrote:
> On Thu, 2007-01-18 at 10:18 +1100, Jens Axboe wrote:
>
> > Can you try io_schedule() and verify that things just work?
>
> I actually did do that in the first place, but wondered if it was the
> right thing to introduce the accounting changes that came with that.
> I'll change it back to io_schedule() and test it again, just to make
> sure.
It appears to be the correct change to me - you really are waiting for
IO resources (otherwise it would not hang with the plug change), so
doing an inc/dec of iowait around the schedule should be done.
> If that's the right fix, I can push it directly since it won't have any
> dependencies on your patches.
Perfect!
--
Jens Axboe
next prev parent reply other threads:[~2007-01-17 23:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 22:55 [PATCH: 2.6.20-rc4-mm1] JFS: Avoid deadlock introduced by explicit I/O plugging Dave Kleikamp
2007-01-17 23:18 ` Jens Axboe
2007-01-17 23:18 ` Jens Axboe
2007-01-17 23:39 ` Dave Kleikamp
2007-01-17 23:46 ` Jens Axboe [this message]
2007-01-18 3:23 ` Dave Kleikamp
2007-01-18 6:30 ` Josef Sipek
2007-01-18 6:30 ` Josef Sipek
2007-01-18 14:15 ` Dave Kleikamp
2007-01-18 14:15 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070117234653.GI3508@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=shaggy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.