All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Pietikainen <pp@ee.oulu.fi>
To: Brandon Craig Rhodes <brandon@rhodesmill.org>
Cc: netdev@vger.kernel.org
Subject: Re: TKIP encryption should allocate enough tailroom
Date: Thu, 18 Jan 2007 15:16:31 +0200	[thread overview]
Message-ID: <20070118131631.GA24622@ee.oulu.fi> (raw)
In-Reply-To: <87mz4h61p0.fsf@ten22.rhodesmill.org>

On Wed, Jan 17, 2007 at 11:46:35AM -0500, Brandon Craig Rhodes wrote:
> Having further reviewed my code, I have changed my mind; the
> ieee80211_crypt_tkip routines are not designed to be responsible for
> creating enough headroom and tailroom.  The "hostap" driver should be
> doing this.  In fact, I now see that the "hostap" driver actually
> attempts to create enough headroom and tailroom, but computes them
> incorrectly.
Even then, if ieee80211_tkip_encrypt() didn't produce debug output for the
not enough space-case, should that be added to catch other
potentially broken drivers?

  parent reply	other threads:[~2007-01-18 13:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-17  2:31 TKIP encryption should allocate enough tailroom Brandon Craig Rhodes
2007-01-17  3:39 ` Mitchell Blank Jr
2007-01-17  3:34   ` Brandon Craig Rhodes
2007-01-17  6:34     ` Herbert Xu
2007-01-17  7:18       ` Herbert Xu
2007-01-17  3:50 ` Michael Wu
2007-01-17 16:46 ` Brandon Craig Rhodes
2007-01-17 17:23   ` Larry Finger
2007-01-17 17:38     ` Brandon Craig Rhodes
2007-01-18 13:16   ` Pekka Pietikainen [this message]
2007-01-18 13:55     ` Brandon Craig Rhodes
2007-01-19 12:23       ` Pekka Pietikainen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070118131631.GA24622@ee.oulu.fi \
    --to=pp@ee.oulu.fi \
    --cc=brandon@rhodesmill.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.