From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhai, Edwin" Subject: Re: [PATCH 8/8] HVM save restore: PV driver support Date: Fri, 19 Jan 2007 19:17:52 +0800 Message-ID: <20070119111752.GS10106@edwin-srv.sh.intel.com> References: <20070111141333.GA2916@edwin-gen.sh.intel.com> <20070119051451.GR10106@edwin-srv.sh.intel.com> <20070119111151.GJ18763@york.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20070119111151.GJ18763@york.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tim Deegan Cc: Ian Pratt , xen-devel@lists.xensource.com, "Zhai, Edwin" List-Id: xen-devel@lists.xenproject.org On Fri, Jan 19, 2007 at 11:11:51AM +0000, Tim Deegan wrote: > Hi Edwin, > > At 13:14 +0800 on 19 Jan (1169212491), Zhai, Edwin wrote: > > thanks for push in save/restore patches, but this one for save/restore > > PV driver on HVM seems to be missing. > > > > if any concerns about this patch, pls. let me know. > > The immediate reason I didn't take this patch is that it changes the > struct page_info definition. It also breaks PV save/restore (though I > haven't yet investigated why). i have met the issue that PV guest restore fail with "can't map p2m_frame_list_..". but after i rebuild everything and try to find root cause, this bug disappeared. i'm not sure if it's a padding issue or something else. > > Since we could take the basic HVM save/restore without this, and we were > keen to code into the tree, I left this out for now. I plan to tidy up > basic HVM save/restore first and then return to PV-on-HVM. I agree > > Cheers, > > Tim. > -- best rgds, edwin