From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Kirstein Subject: Re: [PATCH] fix: growing kernel commandline Date: Fri, 19 Jan 2007 12:59:31 +0100 Message-ID: <20070119125931.A829@web.ray.net> References: <20070117233659.A22236@web.ray.net> <20070119104112.A29181@web.ray.net> <1169202558.6453.16.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1169202558.6453.16.camel@localhost.localdomain>; from Ian.Campbell@XenSource.com on Fri, Jan 19, 2007 at 10:29:18AM +0000 List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ian Campbell List-Id: xen-devel@lists.xenproject.org Hi, > I'm actually just about to push a straight backport of the fix which > went into unstable. If further fixes are required on top of that we > should consider making them in xen-unstable first. I agree for anything further than what I've done. But the switching of ip= and root= parameter in the processing, basically just an exchange of the two blocks: arg_ip = sxp.child_value(image_sxp, 'ip') if arg_ip and not re.search(r'ip=[^ ]+', kernel_args): kernel_args = 'ip=%s ' % arg_ip + kernel_args and: arg_root = sxp.child_value(image_sxp, 'root') if arg_root and not re.search(r'root=', kernel_args): kernel_args = 'root=%s ' % arg_root + kernel_args seems to be riskless, if you do this additional to the -unstable patch we should be on the safe side, I hope :) Otherwise ip= and root= parameter will change their order on the commandline (because they now prepend instead of append themselves), and I thought keeping that intact for bad parsers was the main reason for all of this... That's why I did this change when backporting the fix. (:ul8er, r@y