All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Moore <paul.moore@hp.com>
To: selinux@tycho.nsa.gov
Cc: Antoine Martin <antoine@nagafix.co.uk>,
	Stephen Smalley <sds@tycho.nsa.gov>,
	James Morris <jmorris@namei.org>
Subject: Re: 2.6.19.2 Oops
Date: Fri, 19 Jan 2007 13:07:55 -0500	[thread overview]
Message-ID: <200701191307.56051.paul.moore@hp.com> (raw)
In-Reply-To: <200701191048.30219.paul.moore@hp.com>

On Friday, January 19 2007 10:48 am, Paul Moore wrote:
> On Friday, January 19 2007 10:45 am, Antoine Martin wrote:
> > Disabling Netlabel did the trick.
> > Shouldn't that be sent to stable for 2.6.19.3? (it is a oops after all)
>
> Yep, I'm working on a patch as I type this ...

This patch should solve the problem.  Before I send this off for the stable 
tree does anyone have any comments?

(I'd like to try and send this off by the end of the day today)

---
 security/selinux/ss/mls.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Index: linux-2.6.19.y/security/selinux/ss/mls.c
===================================================================
--- linux-2.6.19.y.orig/security/selinux/ss/mls.c
+++ linux-2.6.19.y/security/selinux/ss/mls.c
@@ -641,10 +641,14 @@ int mls_export_cat(const struct context 
 	int rc = -EPERM;
 
 	if (!selinux_mls_enabled) {
-		*low = NULL;
-		*low_len = 0;
-		*high = NULL;
-		*high_len = 0;
+		if (low != NULL) {
+			*low = NULL;
+			*low_len = 0;
+		}
+		if (high != NULL) {
+			*high = NULL;
+			*high_len = 0;
+		}
 		return 0;
 	}

-- 
paul moore
linux security @ hp

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  parent reply	other threads:[~2007-01-19 18:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-19 10:27 2.6.19.2 Oops Antoine Martin
2007-01-19 13:18 ` Stephen Smalley
2007-01-19 13:26   ` Antoine Martin
2007-01-19 15:45     ` Antoine Martin
2007-01-19 15:48       ` Paul Moore
2007-01-19 15:49         ` Stephen Smalley
2007-01-19 18:07         ` Paul Moore [this message]
2007-01-19 18:12           ` Stephen Smalley
2007-01-19 19:13           ` James Morris
2007-01-19 13:18 ` Paul Moore
2007-01-19 13:24   ` Antoine Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200701191307.56051.paul.moore@hp.com \
    --to=paul.moore@hp.com \
    --cc=antoine@nagafix.co.uk \
    --cc=jmorris@namei.org \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.