From: Matthias Lederhofer <matled@gmx.net>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] prune: --expire=time
Date: Sun, 21 Jan 2007 11:37:24 +0100 [thread overview]
Message-ID: <20070121103724.GA23256@moooo.ath.cx> (raw)
In-Reply-To: <7vlkjw50nl.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> I am considering to commit the attached instead.
Looks fine. Just one question: You said normally unsigned long would
be used for time_t but time_t itself seems to be signed. Using
unsigned long instead of int for prune_grace_period (which is used as
time_t here) results in 'warning: comparison between signed and
unsigned'. Perhaps you want to change it here anyway to be consistent
with the rest of the code (approxidate returns unsigned long too).
next prev parent reply other threads:[~2007-01-21 10:37 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-18 17:18 [PATCH] prune-packed: new option --min-age=N Matthias Lederhofer
2007-01-18 17:24 ` Shawn O. Pearce
2007-01-18 17:42 ` Matthias Lederhofer
2007-01-18 17:51 ` Shawn O. Pearce
2007-01-18 22:29 ` [RFC] prune: --expire=seconds Matthias Lederhofer
2007-01-18 22:32 ` Junio C Hamano
2007-01-19 3:44 ` Shawn O. Pearce
2007-01-19 10:49 ` [PATCH] prune: --expire=time Matthias Lederhofer
2007-01-19 15:41 ` Nicolas Pitre
2007-01-19 19:18 ` Junio C Hamano
2007-01-20 11:18 ` Matthias Lederhofer
2007-01-21 6:55 ` Junio C Hamano
2007-01-21 7:53 ` Shawn O. Pearce
2007-01-21 10:37 ` Matthias Lederhofer [this message]
2007-01-21 11:17 ` Junio C Hamano
2007-01-21 22:01 ` Jeff King
2007-01-22 1:38 ` Steven Grimm
2007-01-22 1:52 ` Jeff King
2007-01-22 2:06 ` Junio C Hamano
2007-01-22 2:23 ` Linus Torvalds
2007-01-22 2:40 ` Junio C Hamano
2007-01-22 2:58 ` Linus Torvalds
2007-01-22 5:17 ` Junio C Hamano
2007-01-22 6:26 ` Linus Torvalds
2007-01-22 6:57 ` Shawn O. Pearce
2007-01-22 7:12 ` Junio C Hamano
2007-01-22 9:32 ` Jakub Narebski
2007-01-22 3:26 ` [PATCH] v1.5.0.txt: update description of git-gc Jeff King
2007-01-22 2:03 ` [PATCH] prune: --expire=time Junio C Hamano
2007-01-20 12:06 ` Simon 'corecode' Schubert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070121103724.GA23256@moooo.ath.cx \
--to=matled@gmx.net \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.