From: Thomas Graf <tgraf@suug.ch>
To: Patrick McHardy <kaber@trash.net>
Cc: Noriaki TAKAMIYA <takamiya@po.ntts.co.jp>,
netdev@vger.kernel.org, usagi-core@linux-ipv6.org
Subject: Re: [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify().
Date: Mon, 22 Jan 2007 13:39:40 +0100 [thread overview]
Message-ID: <20070122123940.GE8693@postel.suug.ch> (raw)
In-Reply-To: <45AE1792.1010002@trash.net>
* Patrick McHardy <kaber@trash.net> 2007-01-17 13:33
> [NETLINK]: Don't BUG on undersized allocations
>
> Currently netlink users BUG when the allocated skb for an event
> notification is undersized. While this is certainly a kernel bug,
> its not critical and crashing the kernel is too drastic, especially
> when considering that these errors have appeared multiple times in
> the past and it BUGs even if no listeners are present.
>
> This patch replaces BUG by WARN_ON and changes the notification
> functions to inform potential listeners of undersized allocations
> using a unique error code (EMSGSIZE).
I perfectly agree, thanks a lot Patrick.
next prev parent reply other threads:[~2007-01-22 12:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-16 3:57 [PATCH] [IPV6] fixed the size of the netlink message notified by inet6_rt_notify() Noriaki TAKAMIYA
2007-01-16 5:01 ` Noriaki TAKAMIYA
2007-01-17 10:50 ` Thomas Graf
2007-01-17 12:33 ` Patrick McHardy
2007-01-18 16:31 ` Noriaki TAKAMIYA
2007-01-19 4:26 ` YOSHIFUJI Hideaki / 吉藤英明
2007-01-22 12:39 ` Thomas Graf [this message]
2007-01-24 6:14 ` David Miller
2007-01-24 6:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070122123940.GE8693@postel.suug.ch \
--to=tgraf@suug.ch \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=takamiya@po.ntts.co.jp \
--cc=usagi-core@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.