All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: nakam@linux-ipv6.org, yoshfuji@linux-ipv6.org,
	takamiya@po.ntts.co.jp, netdev@vger.kernel.org
Subject: Re: [IPV6] RAW: Add checksum default defines for MH.
Date: Tue, 23 Jan 2007 22:59:53 -0800 (PST)	[thread overview]
Message-ID: <20070123.225953.35016491.davem@davemloft.net> (raw)
In-Reply-To: <E1H9c3T-0005HA-00@gondolin.me.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 24 Jan 2007 17:56:23 +1100

> David Miller <davem@davemloft.net> wrote:
> >
> > Did a complete agreement occur that this patch is ok?
> 
> My only concern is that we're putting an arbitrary list of
> protocols in the generic raw.c.  What's the justification
> for including these protocols in particular but not others?
> 
> Is there any reason why the application can't just use the
> existing IPV6_CHECKSUM socket option to set the same fields?

My understanding in the MH case is that the kernel is going
to make changes to the header that the user can't predict
and thus it's impossible for them to set the correct checksum.

I don't know what the justification is for ICMP6 though :-)


  reply	other threads:[~2007-01-24  6:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-03  9:32 [IPV6] RAW: Add checksum default defines for MH Masahide NAKAMURA
2007-01-24  6:19 ` David Miller
2007-01-24  6:56   ` Herbert Xu
2007-01-24  6:59     ` David Miller [this message]
2007-01-24 10:39       ` Masahide NAKAMURA
2007-01-24  7:05     ` YOSHIFUJI Hideaki / 吉藤英明
2007-01-24  7:06       ` Herbert Xu
  -- strict thread matches above, loose matches on Subject: below --
2007-01-03  9:57 Masahide NAKAMURA
2007-02-07  6:43 ` YOSHIFUJI Hideaki / 吉藤英明
2007-02-07  8:04   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070123.225953.35016491.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=nakam@linux-ipv6.org \
    --cc=netdev@vger.kernel.org \
    --cc=takamiya@po.ntts.co.jp \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.