All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhai, Edwin" <edwin.zhai@intel.com>
To: Keir <Keir.Fraser@cl.cam.ac.uk>
Cc: Tim <Tim.Deegan@xensource.com>, xen-devel@lists.xensource.com
Subject: HVM smp guest save/restore support
Date: Tue, 23 Jan 2007 23:34:33 +0800	[thread overview]
Message-ID: <20070123153433.GA10106@edwin-srv.sh.intel.com> (raw)

Keir,

smp save/restore has been reverted in the changeset 13499:
*****************************************
--- a/xen/common/domain.c       Fri Jan 19 11:58:52 2007 +0000
+++ b/xen/common/domain.c       Fri Jan 19 12:03:51 2007 +0000
@@ -506,14 +506,6 @@ int set_info_guest(struct domain *d,
     if ( rc == 0 )
         rc = arch_set_info_guest(v, c);

-    /*XXX: hvm smp guest restore support */
-    if ( rc == 0 &&
-            v->vcpu_id != 0 &&
-            is_hvm_vcpu(v) &&
-            test_and_clear_bit(_VCPUF_down, &v->vcpu_flags) ) {
-        vcpu_wake(v);
-    }
-
     domain_unpause(d);

     xfree(c.nat);
******************************************

this code wake up all the aps like hvm_bringup_ap, since no IPI for ap when 
restore.
if it's slightly ugly, how about add a similar hypercall like xc_domain_resume?

thanks,


-- 
best rgds,
edwin

             reply	other threads:[~2007-01-23 15:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-23 15:34 Zhai, Edwin [this message]
2007-01-23 15:49 ` HVM smp guest save/restore support Keir Fraser
2007-01-24 13:30   ` Zhai, Edwin
2007-01-24 18:32     ` Keir Fraser
2007-01-25  3:30       ` Zhai, Edwin
2007-01-25 12:29         ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070123153433.GA10106@edwin-srv.sh.intel.com \
    --to=edwin.zhai@intel.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=Tim.Deegan@xensource.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.