From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH][RFC] Move some kernel globals from asm file to C file.
Date: Tue, 23 Jan 2007 16:12:26 +0000 [thread overview]
Message-ID: <20070123161226.GA20530@linux-mips.org> (raw)
In-Reply-To: <20070124.003859.126141727.anemo@mba.ocn.ne.jp>
On Wed, Jan 24, 2007 at 12:38:59AM +0900, Atsushi Nemoto wrote:
> 801ce000 B fw_arg3
> 801ce004 B fw_arg1
> 801cf000 B swapper_pg_dir
> 801d0000 B invalid_pte_table
> 801d1000 B fw_arg2
> 801d1008 B kernelsp
> 801d1010 B fw_arg0
> 801d1018 B pgd_current
> 801d1020 A __bss_stop
> 801d1020 A _end
>
> It looks less efficient while fw_arg[0-3] are all 4 byte.
>
> Is there any point on declaring those symbols in asm file? If
> nothing, how about moving them to C file? And I can not see why
> kernel_sp and pgd_current have 8-byte size even on 32-bit kernel.
>
> Here is a proposal patch. Comments?
Looks ok but I think all the pagetable stuff should move to somewhere
like arch/mips/mm/init.c.
Ralf
next prev parent reply other threads:[~2007-01-23 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 15:38 [PATCH][RFC] Move some kernel globals from asm file to C file Atsushi Nemoto
2007-01-23 16:12 ` Ralf Baechle [this message]
2007-01-23 16:21 ` Atsushi Nemoto
2007-01-23 17:04 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070123161226.GA20530@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.