All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Levon <levon@movementarian.org>
To: xen-devel@lists.xensource.com
Subject: save/restore race
Date: Tue, 23 Jan 2007 22:01:45 +0000	[thread overview]
Message-ID: <20070123220145.GA22372@totally.trollied.org.uk> (raw)


save requires a valid arch.pfn_to_mfn_frame_list_list MFN. However,
there is no guarantee that this is up to date, since a previous
restore is considered complete as soon as the domain is unpaused:

        if not paused:
            dominfo.unpause()

        dominfo.completeRestore(handler.store_mfn, handler.console_mfn)

It seems that Linux is being lucky here, in that rebuilding the MFNs is
the first thing it does after suspend(). On Solaris, it occurs somewhat
later in the resume process due to constraints on locking within our MMU
code.

This doesn't seem specific to migration either, a save just after a
restore has completed can hit this race as far as I can see. I'm short
on ideas that don't involve a new interface (like the domain writing
back a xenstore value when it's done resuming). Suggestions?

regards
john

             reply	other threads:[~2007-01-23 22:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-23 22:01 John Levon [this message]
2007-01-23 22:15 ` save/restore race Ian Pratt
2007-01-23 22:48   ` John Levon
2007-01-23 23:38     ` Ian Pratt
2007-01-24  2:10       ` John Levon
2007-01-24  2:19         ` Ian Pratt
2007-01-24  3:13           ` [PATCH] " John Levon
2007-01-24 10:07             ` Steven Hand
2007-02-06 15:04             ` Srikanth SM
2007-02-06 15:13               ` John Levon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070123220145.GA22372@totally.trollied.org.uk \
    --to=levon@movementarian.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.