From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Levon <levon@movementarian.org>
Subject: Re: save/restore race
Date: Tue, 23 Jan 2007 22:48:56 +0000
Message-ID: <20070123224856.GA25347@totally.trollied.org.uk>
References: <20070123220145.GA22372@totally.trollied.org.uk>
	<8A87A9A84C201449A0C56B728ACF491E04F284@liverpoolst.ad.cl.cam.ac.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <8A87A9A84C201449A0C56B728ACF491E04F284@liverpoolst.ad.cl.cam.ac.uk>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

On Tue, Jan 23, 2007 at 10:15:29PM -0000, Ian Pratt wrote:

> Just ignore any new suspend request until you've got the frame list list
> rebuilt.

see xc_linux_save.c:

 667     live_p2m_frame_list_list =
 668         xc_map_foreign_range(xc_handle, dom, PAGE_SIZE, PROT_READ,
 669 live_shinfo->arch.pfn_to_mfn_frame_list_list);

...

1087                 if (suspend_and_state(suspend, xc_handle, io_fd, dom, &info,
1088                                       &ctxt)) {
1089                     ERROR("Domain appears not to have suspended");
1090                     goto out;
1091                 }

We use the value long before the domain is told to suspend.

regards
john