All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Buesch <mb@bu3sch.de>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: John Linville <linville@tuxdriver.com>,
	netdev@vger.kernel.org, Bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] bcm43xx: Fix scaling error for 'iwlist freq' information
Date: Wed, 24 Jan 2007 00:04:01 +0100	[thread overview]
Message-ID: <200701240004.01943.mb@bu3sch.de> (raw)
In-Reply-To: <45b68f8e.m8+Bl9ZfRL/zvhGv%Larry.Finger@lwfinger.net>

On Tuesday 23 January 2007 23:43, Larry Finger wrote:
> The bcm43xx driver returns the available frequencies to 'iwlist freq' with the wrong scaling.
> 
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> 
> John,
> 
> This is to be applied to wireless-2.6. It could also be sent upstream to 2.6.20,
> but it is not very important.

ACKed. The previous rates-fix patch is also ACKed.

> Larry
> ---
> 
> Index: wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
> +++ wireless-2.6/drivers/net/wireless/bcm43xx/bcm43xx_wx.c
> @@ -286,7 +286,7 @@ static int bcm43xx_wx_get_rangeparams(st
>  		if (j == IW_MAX_FREQUENCIES)
>  			break;
>  		range->freq[j].i = j + 1;
> -		range->freq[j].m = geo->a[i].freq;//FIXME?
> +		range->freq[j].m = geo->a[i].freq * 100000;
>  		range->freq[j].e = 1;
>  		j++;
>  	}
> @@ -294,7 +294,7 @@ static int bcm43xx_wx_get_rangeparams(st
>  		if (j == IW_MAX_FREQUENCIES)
>  			break;
>  		range->freq[j].i = j + 1;
> -		range->freq[j].m = geo->bg[i].freq;//FIXME?
> +		range->freq[j].m = geo->bg[i].freq * 100000;
>  		range->freq[j].e = 1;
>  		j++;
>  	}
> 
> ---
> 
> 
> 

-- 
Greetings Michael.

      reply	other threads:[~2007-01-23 23:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-23 22:43 [PATCH] bcm43xx: Fix scaling error for 'iwlist freq' information Larry Finger
2007-01-23 23:04 ` Michael Buesch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200701240004.01943.mb@bu3sch.de \
    --to=mb@bu3sch.de \
    --cc=Bcm43xx-dev@lists.berlios.de \
    --cc=Larry.Finger@lwfinger.net \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.