From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@ozlabs.org
Cc: paulus@samba.org
Subject: Re: [PATCH 10/14] ps3: get firmware version
Date: Thu, 25 Jan 2007 07:23:48 +0100 [thread overview]
Message-ID: <200701250723.48555.arnd@arndb.de> (raw)
In-Reply-To: <45B81891.1010309@am.sony.com>
On Thursday 25 January 2007 03:40, Geoff Levand wrote:
> Output the PS3 firmware version to dmesg and /proc/cpuinfo.
>
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
>
Acked-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
I agree with benh that you should avoid the copy of individual fields
inside of the struct ps3_firmware_version, since you can directly
read into a
struct ps3_firmware_version {
u16 pad;
u16 major;
u16 minor;
u16 rev;
};
next prev parent reply other threads:[~2007-01-25 6:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 2:40 [PATCH 10/14] ps3: get firmware version Geoff Levand
2007-01-25 3:56 ` Benjamin Herrenschmidt
2007-01-25 6:23 ` Arnd Bergmann [this message]
2007-01-26 2:59 ` Christoph Hellwig
2007-01-26 18:52 ` Geoff Levand
2007-01-26 20:25 ` Benjamin Herrenschmidt
2007-01-26 20:37 ` Nathan Lynch
2007-01-26 23:12 ` Geoff Levand
2007-01-26 23:27 ` Geoff Levand
2007-01-27 4:34 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200701250723.48555.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.