From: "Shawn O. Pearce" <spearce@spearce.org>
To: "Horst H. von Brand" <vonbrand@inf.utfsm.cl>
Cc: Nicolas Pitre <nico@cam.org>, Junio C Hamano <junkio@cox.net>,
git@vger.kernel.org
Subject: Re: [PATCH] Hash name is SHA-1
Date: Thu, 25 Jan 2007 14:05:16 -0500 [thread overview]
Message-ID: <20070125190516.GD13089@spearce.org> (raw)
In-Reply-To: <200701251856.l0PIu8pP032403@laptop13.inf.utfsm.cl>
"Horst H. von Brand" <vonbrand@inf.utfsm.cl> wrote:
> Nicolas Pitre <nico@cam.org> wrote:
> > Maybe the patch could be restricted to documentation fixes only for now?
>
> That's what I tried to do. But just changing the documentation without
> changing (some) of the messages and so on just gets you worse
> inconsistency.
I'm not at all against updating output messages to match the
documentation. Indeed, its good to make them consistent.
It just would be a lot easier to review the patch if it wasn't 1600+
lines, _especially_ when some of the hunks really aren't related
to the theme of the patch.
Of course with the amount of time I've now spent writing email
saying how hard it is to review the original patch, I could have just
read through the entire thing and given it another set of eyeballs.
Argh, another great misuse of my time. :-)
--
Shawn.
next prev parent reply other threads:[~2007-01-25 19:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 12:50 Some cleanups Horst H. von Brand
2007-01-25 12:50 ` [PATCH] Hash name is SHA-1 Horst H. von Brand
2007-01-25 17:01 ` Shawn O. Pearce
2007-01-25 17:10 ` Nicolas Pitre
2007-01-25 18:56 ` Horst H. von Brand
2007-01-25 19:05 ` Shawn O. Pearce [this message]
2007-01-25 23:03 ` Matthias Lederhofer
2007-01-25 23:44 ` Junio C Hamano
2007-01-26 11:54 ` Andy Parkins
2007-01-26 23:46 ` Junio C Hamano
2007-01-26 11:34 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070125190516.GD13089@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=nico@cam.org \
--cc=vonbrand@inf.utfsm.cl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.