From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add support for the MPC8349E-mITX-GP
Date: Thu, 25 Jan 2007 19:17:09 -0600 [thread overview]
Message-ID: <20070125191709.457ccbf4.kim.phillips@freescale.com> (raw)
In-Reply-To: <1169046585794-git-send-email-timur@freescale.com>
On Wed, 17 Jan 2007 09:09:45 -0600
timur at freescale.com wrote:
> From: Timur Tabi <timur@freescale.com>
>
> Add support for the MPC8349E-mITX-GP, a stripped-down version of the
> MPC8349E-mITX.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
> MAINTAINERS | 1 +
> Makefile | 16 ++-
> board/mpc8349itx/config.mk | 6 +-
> board/mpc8349itx/mpc8349itx.c | 105 ++--------
> include/configs/MPC8349ITX.h | 463 ++++++++++++++++-------------------------
> include/mpc83xx.h | 41 ++++
Timur, this looks good except new boards should at least have their own config file;
I have a problem with multiple ifdef CONFIG_MPC8349ITX checks in MPC8349ITX.h.
Also, there are unrelated modifications in this patch - please respin.
Thanks,
Kim
next prev parent reply other threads:[~2007-01-26 1:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 15:09 [U-Boot-Users] [PATCH] Add support for the MPC8349E-mITX-GP timur at freescale.com
2007-01-26 1:17 ` Kim Phillips [this message]
2007-01-26 4:41 ` Timur Tabi
2007-01-26 5:57 ` Kumar Gala
2007-01-26 9:46 ` Wolfgang Denk
2007-01-26 17:19 ` Kim Phillips
2007-01-26 17:38 ` Timur Tabi
2007-01-26 21:17 ` Wolfgang Denk
2007-01-26 21:24 ` Timur Tabi
2007-01-26 21:46 ` Wolfgang Denk
2007-01-26 21:49 ` Timur Tabi
2007-01-27 0:37 ` Wolfgang Denk
2007-01-29 10:07 ` Stefan Roese
2007-01-26 21:11 ` Wolfgang Denk
2007-01-26 9:42 ` Wolfgang Denk
2007-01-26 14:45 ` Timur Tabi
2007-01-26 14:58 ` Wolfgang Denk
2007-01-26 15:03 ` Timur Tabi
2007-01-26 15:37 ` Wolfgang Denk
-- strict thread matches above, loose matches on Subject: below --
2007-01-31 21:54 Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070125191709.457ccbf4.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.