Re: [PATCH 7/9] ps3: disable display flipping during mode changes

[Arnd Bergmann <arnd@arndb.de>]

On Thursday 25 January 2007 18:51, Geert Uytterhoeven wrote:
> @@ -33,6 +33,12 @@
>  #define DPRINTK(fmt, args...) do { } while (0)
>  #endif
>  
> +#ifdef CONFIG_FB_PS3
> +extern int ps3fb_flip_ctl(int);
> +#else
> +#define ps3fb_flip_ctl(x)
> +#endif

The empty function should by convention be defined as
'do { } while (0)', like the DPRINTK above.
Even better might be an empty inline function

static inline int ps3fb_flip_ctl(int arg)
{
	return 0;
}

that enables type checking in gcc.

	Arnd <><