All of lore.kernel.org
 help / color / mirror / Atom feed
From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] patch to bmcsensors.c
Date: Fri, 26 Jan 2007 08:15:09 +0000	[thread overview]
Message-ID: <20070126091509.4cf01e79.khali@linux-fr.org> (raw)
In-Reply-To: <000501c740d5$85a39350$8101a8c0@PERF.PERFORMANCESOFTWARE>

Hi Charles,

On Thu, 25 Jan 2007 16:07:00 -0700, Charles Grant wrote:
> Here are some changes I made to get bmcsensors working on our dual-core Xeon
> ATCA carrier (Kontron 8020).
> 
> 1) I modified the code to send an initial "get device ID" command to
> determine which commands are used to subsequently retrieve the SDR data
> (this code was taken directly from ipmitool).
> 
> 2) When retrieving partial buffers for an SDR, the request for the last
> buffer would return completion code 0xCA (cannot return number of requested
> data bytes), causing the code to half its buffer size, try again, and
> ultimately give up.  To get around this, I modified bmcsensors_get_sdr() and
> bmcsensors_rcv_sdr_msg() to never request more than the known number of
> remaining bytes.
> 
> 3) Sorry, but I also put "#ifdef DEBUG" around a lot of the printk's

Please send 3 separate patches, as these 3 changes appear to be
independent from each other. Smaller patches have a much higher chance
to be reviewed and merged.

Thanks,
-- 
Jean Delvare


      reply	other threads:[~2007-01-26  8:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 23:07 [lm-sensors] patch to bmcsensors.c Charles Grant
2007-01-26  8:15 ` Jean Delvare [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070126091509.4cf01e79.khali@linux-fr.org \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.