From: Jarek Poplawski <jarkao2@o2.pl>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>,
davem@davemloft.net, yoshfuji@linux-ipv6.org, mhuth@mvista.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] TCP: Replace __kfree_skb() with kfree_skb()
Date: Fri, 26 Jan 2007 11:18:38 +0100 [thread overview]
Message-ID: <20070126101838.GC1639@ff.dom.local> (raw)
In-Reply-To: <20070126095251.GA24204@gondor.apana.org.au>
On Fri, Jan 26, 2007 at 08:52:51PM +1100, Herbert Xu wrote:
> On Fri, Jan 26, 2007 at 10:49:50AM +0100, Jarek Poplawski wrote:
> >
> > How do we know about those improper deals?
> > I understand there should be no other users here
> > if it's __kfree_skb now. So I mean to test and warn
> > before kfree_skb for some debugging time.
>
> We only need to do that if there is a legitimate reason to use
> __kfree_skb. Which there was when this code was first written
> since kfree_skb had an unconditional atomic op back then.
>
> Now that it's a conditinoal atomic op __kfree_skb is no longer
> necessary.
I don't mean it's necessary. I mean now skb is freed
unconditionally and after this patch, if there is some
error in counting, skb will stay. I thought Masayuki
wrote about such possibility, but if I missed his
point, then the rest is really O.K.
Cheers,
Jarek P.
next prev parent reply other threads:[~2007-01-26 10:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-26 3:37 [PATCH] TCP: Replace __kfree_skb() with kfree_skb() Masayuki Nakagawa
2007-01-26 8:28 ` Jarek Poplawski
2007-01-26 9:16 ` Herbert Xu
2007-01-26 9:49 ` Jarek Poplawski
2007-01-26 9:52 ` Herbert Xu
2007-01-26 10:18 ` Jarek Poplawski [this message]
2007-01-26 10:45 ` Herbert Xu
2007-01-26 10:58 ` David Miller
2007-01-26 11:02 ` Jarek Poplawski
2007-01-26 13:18 ` Jarek Poplawski
2007-01-26 14:05 ` Jarek Poplawski
2007-01-26 14:19 ` Alexey Kuznetsov
2007-01-29 8:26 ` Jarek Poplawski
2007-01-29 10:38 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070126101838.GC1639@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=mhuth@mvista.com \
--cc=nakagawa.msy@ncos.nec.co.jp \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.