All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Viro <aviro@redhat.com>
To: "Timothy R. Chavez" <tinytim@us.ibm.com>
Cc: linux-audit@redhat.com
Subject: Re: close(2) not being audited?
Date: Fri, 26 Jan 2007 18:20:51 -0500	[thread overview]
Message-ID: <20070126232051.GG14621@devserv.devel.redhat.com> (raw)
In-Reply-To: <20070126170112.6ac08156@crumpet>

On Fri, Jan 26, 2007 at 05:01:12PM -0600, Timothy R. Chavez wrote:
> > Please, define "access".  Consider the following sequence:
> > 	on April 1st:
> > 	fd = open(foo, O_RDWR);
> > 	p = mmap(..., fd, ...);
> > 	close(fd);
> > 	two days later: modify area pointed to by p
> > 	a month later: munmap(p, ...);
> > 
> > What do you want in the log?  More specifically, _when_ do you want it?
> 
> Write out a log when the last reference to the fd is put back... whether
> that's from a close or an munmap.

Sigh...  One more time: there are two distinct classes of objects - opened
files and opened descriptors.  That's the point - by the time of munmap()
there is no file descriptor at all.  It's been gone for a month.

Descriptor getting closed != file getting closed.  If you are talking about
the last reference to opened file - OK.  But there won't necessary be
any descriptors refering to it.

  reply	other threads:[~2007-01-26 23:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-28 21:58 close(2) not being audited? Todd, Charles
2006-12-30 14:36 ` Steve Grubb
2007-01-26 17:37 ` Steve Grubb
2007-01-26 18:03   ` John D. Ramsdell
2007-01-26 20:14   ` Wieprecht, Karen M.
2007-01-26 22:19     ` Alexander Viro
2007-01-26 23:00       ` Timothy R. Chavez
2007-01-26 23:01       ` Timothy R. Chavez
2007-01-26 23:20         ` Alexander Viro [this message]
2007-01-26 23:46           ` Timothy R. Chavez
2007-01-28 21:40             ` James Antill
2007-01-29 20:19               ` Timothy R. Chavez
2007-01-26 23:29         ` Alexander Viro
2007-01-27  0:03           ` Timothy R. Chavez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070126232051.GG14621@devserv.devel.redhat.com \
    --to=aviro@redhat.com \
    --cc=linux-audit@redhat.com \
    --cc=tinytim@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.