From: Christoph Hellwig <hch@infradead.org>
To: Zwane Mwaikambo <zwane@infradead.org>
Cc: Dave Jones <davej@redhat.com>, Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] AGPGART compat ioctl
Date: Sun, 28 Jan 2007 08:36:44 +0000 [thread overview]
Message-ID: <20070128083644.GA8677@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0701271403420.1379@montezuma.fsmlabs.com>
On Sat, Jan 27, 2007 at 07:28:07PM -0800, Zwane Mwaikambo wrote:
> --- linux-2.6.20-rc4-mm1/include/linux/agpgart.h 27 Jan 2007 22:04:06 -0000 1.1.1.1
> +++ linux-2.6.20-rc4-mm1/include/linux/agpgart.h 27 Jan 2007 22:41:23 -0000
> @@ -114,6 +114,67 @@ typedef struct _agp_unbind {
>
> #define AGPGART_MINOR 175
>
> +#ifdef CONFIG_COMPAT
> +#include <linux/compat.h>
I don't think this should be in public headers. I'd rather have all
declarations and code for compat ioctl handling in a single file,
e.g. drivers/char/agp/compat_ioctl.c
> +#ifdef CONFIG_COMPAT
> +static int compat_agpioc_info_wrap(struct agp_file_private *priv, void __user *arg)
Please make sure this doesn't overflow 80 characters per line.
next prev parent reply other threads:[~2007-01-28 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-28 3:28 [PATCH] AGPGART compat ioctl Zwane Mwaikambo
2007-01-28 8:36 ` Christoph Hellwig [this message]
2007-01-30 5:20 ` Zwane Mwaikambo
2007-01-31 3:03 ` Kyle McMartin
2007-01-31 5:50 ` Zwane Mwaikambo
2007-01-31 20:15 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070128083644.GA8677@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.