From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Christoph Egger" <Christoph.Egger@amd.com>
Subject: Re: [PATCH 1/3] Use string bound functions (take
 #2)
Date: Mon, 29 Jan 2007 15:51:01 +0100
Message-ID: <200701291551.01187.Christoph.Egger@amd.com>
References: <200701291525.18001.Christoph.Egger@amd.com>
	<1B6A3F76-2E6E-46B4-BAA5-B308294E8175@xensource.com>
Mime-Version: 1.0
Content-Type: text/plain;
 charset=iso-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1B6A3F76-2E6E-46B4-BAA5-B308294E8175@xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: Anil Madhavapeddy <anil@xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Monday 29 January 2007 15:37, Anil Madhavapeddy wrote:
> I notice these aren't checking for buffer truncation.  Might be worth
> putting checks for this in places where it matters and not silently
> truncate the string (e.g. the domain builder).

Yeah. I think, this should be done in another patch. Most important is,
that strlcpy() is used rather strncpy().

Christoph

>
> -anil
>
> On 29 Jan 2007, at 14:25, Christoph Egger wrote:
> > <xen_stringbound.diff>