From: Aron Griffis <aron@hp.com>
To: xen-devel@lists.xensource.com
Subject: Re: Re: [Xen-staging] [xen-unstable] ia64 and ppc: Remove uses of strcpy and strncpy.
Date: Mon, 29 Jan 2007 19:06:09 -0500 [thread overview]
Message-ID: <20070130000608.GD27235@fc.hp.com> (raw)
In-Reply-To: <20070129235356.GC27235@fc.hp.com>
Aron Griffis wrote: [Mon Jan 29 2007, 06:53:57PM EST]
> Additionally...
>
> Xen staging patchbot-unstable wrote: [Mon Jan 29 2007, 10:02:21AM EST]
> > --- a/xen/arch/ia64/xen/gdbstub.c Mon Jan 29 14:59:42 2007 +0000
> > +++ b/xen/arch/ia64/xen/gdbstub.c Mon Jan 29 15:01:33 2007 +0000
> > @@ -639,7 +639,7 @@ kgdb_get_reg(int regnum, struct unw_fram
> > outbuffer[size*2] = 0;
> > }
> > else
> > - strcpy(outbuffer, "E0");
> > + strlcpy(outbuffer, "E0", sizeof("E0"));
>
> Better to use safe_strcpy here instead of duplicating
My mistake here. safe_strcpy uses sizeof(dst) not sizeof(src). Your
change seems like the best choice in the absence of strcpy()
prev parent reply other threads:[~2007-01-30 0:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200701291502.l0TF2Md1000372@latara.uk.xensource.com>
2007-01-29 23:47 ` [Xen-staging] [xen-unstable] ia64 and ppc: Remove uses of strcpy and strncpy Aron Griffis
2007-01-30 7:11 ` Christoph Egger
2007-01-30 13:25 ` Alex Williamson
2007-01-30 13:50 ` Aron Griffis
2007-01-29 23:53 ` Aron Griffis
2007-01-30 0:06 ` Aron Griffis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070130000608.GD27235@fc.hp.com \
--to=aron@hp.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.